abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Remy Gendron" <r...@arrova.ca>
Subject RE: DELETE of inexisting resource... weak api
Date Wed, 09 Apr 2008 18:55:50 GMT
You are right in that the end result will be the same as returning an
EmptyResponseContext(404).

However, some logging will occur that could have someone believe that an
error occurred. More importantly, the ClientResponse.getType() will return
CLIENT_ERROR. A 404 on a GET or PUT returns a ResponseType.SUCCESS.

Remy

-----Original Message-----
From: Dan Diephouse [mailto:dan.diephouse@mulesource.com] 
Sent: April 9, 2008 14:30
To: abdera-dev@incubator.apache.org
Subject: Re: DELETE of inexisting resource... weak api

Hi,
Couldn't you just do "throw new ResponseContextException(404);" ?

Dan

Remy Gendron wrote:
> Hi all,
>
>  
>
> GET and PUT properly handle an invalid resource request and return a 404.
>
>  
>
> However, the way the delete is handled in AbstractEntityCollectionAdapter
> does not allow the implementation to indicate that a 404 should be
returned.
>
>  
>
> Currently, all I can do is throw an exception and have Abdera return an
> error or (this is what I do), still return a 204 if the entry does not
> exist.
>
>  
>
> Maybe void AbstractEntityCollectionAdapter.deleteEntry(String,
> RequestContext) should be refactored to either return a Boolean or an
> EmpyResponseContext.
>
>  
>
> Should I enter a JIRA?
>
>  
>
> Thanks again for the great work!
>
>  
>
>  
>
> Rémy
>
>
>   


-- 
Dan Diephouse
MuleSource
http://mulesource.com | http://netzooid.com 



-- 
No virus found in this incoming message.
Checked by AVG. 
Version: 7.5.519 / Virus Database: 269.22.10/1367 - Release Date: 09/04/2008
7:10 AM



Mime
View raw message