abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dan Diephouse <dan.diepho...@mulesource.com>
Subject Re: DELETE of inexisting resource... weak api
Date Wed, 09 Apr 2008 19:11:16 GMT
OK. I think the right fix is to:
1. Log the ResponseContextExceptions at DEBUG if status code < 500. 
(Could've sworn I did this before...)
2. Fix the client side of it so it returns a SUCCESS on 404 and DELETE

Re: JIRA - that would be great!

Dan

Remy Gendron wrote:
> Effectively, my console is now full of stack traces when I run my unit
> tests, as I have my root logger set to INFO.
>
> Remy
>
> -----Original Message-----
> From: Dan Diephouse [mailto:dan.diephouse@mulesource.com] 
> Sent: April 9, 2008 14:30
> To: abdera-dev@incubator.apache.org
> Subject: Re: DELETE of inexisting resource... weak api
>
> Hi,
> Couldn't you just do "throw new ResponseContextException(404);" ?
>
> Dan
>
> Remy Gendron wrote:
>   
>> Hi all,
>>
>>  
>>
>> GET and PUT properly handle an invalid resource request and return a 404.
>>
>>  
>>
>> However, the way the delete is handled in AbstractEntityCollectionAdapter
>> does not allow the implementation to indicate that a 404 should be
>>     
> returned.
>   
>>  
>>
>> Currently, all I can do is throw an exception and have Abdera return an
>> error or (this is what I do), still return a 204 if the entry does not
>> exist.
>>
>>  
>>
>> Maybe void AbstractEntityCollectionAdapter.deleteEntry(String,
>> RequestContext) should be refactored to either return a Boolean or an
>> EmpyResponseContext.
>>
>>  
>>
>> Should I enter a JIRA?
>>
>>  
>>
>> Thanks again for the great work!
>>
>>  
>>
>>  
>>
>> Rémy
>>
>>
>>   
>>     
>
>
>   


-- 
Dan Diephouse
MuleSource
http://mulesource.com | http://netzooid.com 


Mime
View raw message