abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dan Diephouse (JIRA)" <j...@apache.org>
Subject [jira] Closed: (ABDERA-144) Unecessary logging on DELETE on 404s
Date Thu, 17 Apr 2008 21:25:21 GMT

     [ https://issues.apache.org/jira/browse/ABDERA-144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Dan Diephouse closed ABDERA-144.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.5.0

Fixed in: http://svn.apache.org/viewvc?rev=649280&view=rev

> Unecessary logging on DELETE on 404s
> ------------------------------------
>
>                 Key: ABDERA-144
>                 URL: https://issues.apache.org/jira/browse/ABDERA-144
>             Project: Abdera
>          Issue Type: Improvement
>    Affects Versions: 0.4.0
>            Reporter: Remy Gendron
>             Fix For: 0.5.0
>
>         Attachments: debug_exceptions_minior_than_500.patch
>
>
> target: AbstractEntityCollectionAdapter.deleteEntry(String, RequestContext)
> If the resource does not exist, throw new ResponseContextException(404) will generate
logging at the INFO level. The exception is not an error but used to control program flow.
As Dan says:
> OK. I think the right fix is to:
> 1. Log the ResponseContextExceptions at DEBUG if status code < 500. 
> (Could've sworn I did this before...)
> 2. Fix the client side of it so it returns a SUCCESS on 404 and DELETE
> But, James correctly says:
> 404 is a client error as defined by RFC 2616.  Defining it as a SUCCESS would be a bug
and would break existing code.  For 404,
> getType() should return CLIENT_ERROR and the client needs to check the status code.
> Thus, my initial report that SUCCESS should be returned was wrong.
> Only the logging issue need be fixed.
> Thanks.
> Remy

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message