Return-Path: Delivered-To: apmail-incubator-abdera-dev-archive@locus.apache.org Received: (qmail 15631 invoked from network); 3 Feb 2008 01:30:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Feb 2008 01:30:47 -0000 Received: (qmail 12366 invoked by uid 500); 3 Feb 2008 01:30:39 -0000 Delivered-To: apmail-incubator-abdera-dev-archive@incubator.apache.org Received: (qmail 12352 invoked by uid 500); 3 Feb 2008 01:30:39 -0000 Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: abdera-dev@incubator.apache.org Delivered-To: mailing list abdera-dev@incubator.apache.org Received: (qmail 12343 invoked by uid 99); 3 Feb 2008 01:30:39 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Feb 2008 17:30:39 -0800 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of rooneg@gmail.com designates 209.85.198.186 as permitted sender) Received: from [209.85.198.186] (HELO rv-out-0910.google.com) (209.85.198.186) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 03 Feb 2008 01:30:11 +0000 Received: by rv-out-0910.google.com with SMTP id k20so1186680rvb.0 for ; Sat, 02 Feb 2008 17:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=5WhFaOeyRnIveeq2Gr07+gIZ8K0ggeg9qrc+1evHxDc=; b=GZ6BYbT5RHy516cW4Zq8EpwEU2AhWNdQlhlUkR0C0UqetToXhZFkk1r6bxHo1czgtzP42PexFnjIj0CLgPnHQYHwSk22z13qEXVFmvq6C0bghzG4tsCmSVZEEp2fkHpBkDmWWGBhsHs6iHj6THKGjuqVo30hd5Q/ukMxiAeCEVA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=w8qammapDnyc2QAIfBeGlyX/mqVs1cYlVYxfXpfpHP9fbdZ08p0zo8dksm3BLxFHATc/2OPrDLGCbH71CLqAuRufDkbykOHgIkTowE7nvHGul3Sd909JE6ftixovE3bfGhaP4eSHK3i5YkrAtHFKJEucMBR7Lc2gcxSnEiJKJk4= Received: by 10.141.161.6 with SMTP id n6mr3617086rvo.155.1202002218377; Sat, 02 Feb 2008 17:30:18 -0800 (PST) Received: by 10.140.165.20 with HTTP; Sat, 2 Feb 2008 17:30:18 -0800 (PST) Message-ID: <7edfeeef0802021730s21d4602dw66bea943d97c1fc7@mail.gmail.com> Date: Sat, 2 Feb 2008 20:30:18 -0500 From: "Garrett Rooney" Sender: rooneg@gmail.com To: abdera-dev@incubator.apache.org Subject: Re: svn commit: r617935 - /incubator/abdera/java/trunk/extensions/json/src/main/java/org/apache/abdera/ext/json/JSONUtil.java In-Reply-To: <20080203004542.E50341A9832@eris.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080203004542.E50341A9832@eris.apache.org> X-Google-Sender-Auth: c1edbad5f3ce0041 X-Virus-Checked: Checked by ClamAV on apache.org On Feb 2, 2008 7:45 PM, wrote: > @@ -397,7 +395,11 @@ > "src".equalsIgnoreCase(name) || > "action".equalsIgnoreCase(name))) { > IRI base = child.getResolvedBaseUri(); > - val = UrlEncoding.encode(val.trim(),Profile.IUNRESERVED.filter(),Profile.RESERVED.filter(),Profile.IPRIVATE.filter()); > +// val = UrlEncoding.encode( > +// val.trim(), > +// Profile.IUNRESERVED.filter(), > +// Profile.RESERVED.filter(), > +// Profile.IPRIVATE.filter()); > if (base != null) val = base.resolve(val).toASCIIString(); Umm, if there's an escaping bug in this code can you do more than just comment it out? Either remove the code entirely or if it must remain at least leave a comment describing why it's commented out. I never understand why people comment out code like this. We have a version control system, if we need to get it back it's a simple 'svn merge' away... -garrett