abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jun Yang" <jyang...@gmail.com>
Subject Re: JdbcCollectionAdapter class name is ambiguous
Date Tue, 12 Feb 2008 20:05:03 GMT
On Feb 12, 2008 11:24 AM, Vasudeva Nori <vasunori@gmail.com> wrote:

> package name of "ibatis" sounds confusing to me.
> class name of IbatisAdapter sounds ok under the package of
> DatabaseAdapters.
>

SqlMapAdapter sounds good to me.  It is more precise than JdbcAdapter.

Jun


> since David Calavera is planning on building a HybernateAdapter (thanks
> david), it can directly go into this package and one will have a variety
> of
> database adapters to choose from.
>
> so these adapters could live in adapters/DatabaseAdapters package, unlike
> JcrAdapter and couchdb adapter.
> an extra level of package depth for these adapters..don't know how people
> feel about that.
>
>
> On Feb 12, 2008 10:55 AM, David Primmer <david.primmer@gmail.com> wrote:
>
> > Lets hope there will be lots of adapters and people will have some
> > sort of naming system to follow so that their new adapter can fit into
> > a product space with other adpaters. I won't be a stickler on the
> > package names. But what if we had some other method of applying this
> > metadata? I'm thinking more of a directory that would list these
> > adapters rather than requiring someone hunt through source code. High
> > level categories for what you want to do and then tag the specific
> > adapaters with implementation details. We will have several database
> > adapters that are all common in that they do some sql at some point.
> > But we should also be able to add more metadata. Think about how
> > firefox or eclipse plugin sites work.
> >
> > davep
> >
> > On Feb 12, 2008 10:22 AM, James M Snell <jasnell@gmail.com> wrote:
> > > Let's assume we end up with several db-to-atom adapters based on
> several
> > > mapping layers, say raw jdbc, ibatis, and hibernate.  What should the
> > > names of the various adapters be?  At a high enough level, they all do
> > > the same thing: adapt data from a database.  In theory, each could
> exist
> > > within a single package, but they certainly need to have
> > > implementation-specific class names.
> > >
> > > - James
> > >
> > >
> > >
> > >
> > > David Primmer wrote:
> > > > I have an objection to this. It focuses too much on implementation
> > details.
> > > > I'd prefer to go the other way towards a name that describes what it
> > does,
> > > > not how it does it. You're not adapting iBatis, you're adapting data
> > from a
> > > > database. There must be another way to say this. The package
> namespace
> > seems
> > > > to make sense but not the class name.
> > > > davep
> > > >
> > > > On Feb 12, 2008 5:11 AM, David Calavera <david.calavera@gmail.com>
> > wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> I've seen JdbcCollectionAdapter depends on IBatis and I think the
> > name is
> > > >> ambiguous when I read "Jdbc" I think on a native jdbc connection to
> > the
> > > >> database without orms. I think we should rename this class to
> > > >> IBatisCollectionAdapter and move it to some other package like "
> > > >> org.apache.abdera.protocol.server.adapters.orm.ibatis".
> > > >>
> > > >> Unless you have no problem, I'm going to create the jira issue and
> > submit
> > > >> a
> > > >> patch.
> > > >>
> > > >> Btw, I'm thinking on create an HibernateCollectionAdapter XD.
> > > >>
> > > >> Cheers
> > > >>
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message