abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Garrett Rooney" <roo...@electricjellyfish.net>
Subject Re: svn commit: r617935 - /incubator/abdera/java/trunk/extensions/json/src/main/java/org/apache/abdera/ext/json/JSONUtil.java
Date Sun, 03 Feb 2008 01:30:18 GMT
On Feb 2, 2008 7:45 PM,  <jmsnell@apache.org> wrote:

> @@ -397,7 +395,11 @@
>               "src".equalsIgnoreCase(name) ||
>               "action".equalsIgnoreCase(name))) {
>           IRI base = child.getResolvedBaseUri();
> -         val = UrlEncoding.encode(val.trim(),Profile.IUNRESERVED.filter(),Profile.RESERVED.filter(),Profile.IPRIVATE.filter());
> +//         val = UrlEncoding.encode(
> +//           val.trim(),
> +//           Profile.IUNRESERVED.filter(),
> +//           Profile.RESERVED.filter(),
> +//           Profile.IPRIVATE.filter());
>           if (base != null) val = base.resolve(val).toASCIIString();

Umm, if there's an escaping bug in this code can you do more than just
comment it out?  Either remove the code entirely or if it must remain
at least leave a comment describing why it's commented out.

I never understand why people comment out code like this.  We have a
version control system, if we need to get it back it's a simple 'svn
merge' away...

-garrett

Mime
View raw message