abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "vasu nori (JIRA)" <j...@apache.org>
Subject [jira] Created: (ABDERA-121) adding namespace declarations in feed needs ot be modified
Date Fri, 15 Feb 2008 19:36:08 GMT
adding namespace declarations in feed needs ot be modified
----------------------------------------------------------

                 Key: ABDERA-121
                 URL: https://issues.apache.org/jira/browse/ABDERA-121
             Project: Abdera
          Issue Type: Improvement
            Reporter: vasu nori


in IBatisCollectionAdapter.java,  the method getFeed() is adding a namespacePrefix unconditionally,
even if it can be null or blank.
(can happen if I extend BasicServerConfiguration class and override getFeedNameSpace methods
to return null or empty strings)

There should be a line around it to make sure it is not null or not empty.

line#86 currently is
          feed.declareNS(serverConfig.getFeedNamespace(), serverConfig.getFeedNamespacePrefix());

should be
       if (serverConfig.getFeedNamespacePrefix() != null && serverConfig.getFeedNamespacePrefix().length()
> 0)
          feed.declareNS(serverConfig.getFeedNamespace(), serverConfig.getFeedNamespacePrefix());

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message