Return-Path: Delivered-To: apmail-incubator-abdera-dev-archive@locus.apache.org Received: (qmail 34011 invoked from network); 24 Jun 2007 16:19:19 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Jun 2007 16:19:19 -0000 Received: (qmail 77779 invoked by uid 500); 24 Jun 2007 16:19:22 -0000 Delivered-To: apmail-incubator-abdera-dev-archive@incubator.apache.org Received: (qmail 77722 invoked by uid 500); 24 Jun 2007 16:19:22 -0000 Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: abdera-dev@incubator.apache.org Delivered-To: mailing list abdera-dev@incubator.apache.org Received: (qmail 77713 invoked by uid 99); 24 Jun 2007 16:19:22 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Jun 2007 09:19:22 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [209.68.5.17] (HELO relay03.pair.com) (209.68.5.17) by apache.org (qpsmtpd/0.29) with SMTP; Sun, 24 Jun 2007 09:19:17 -0700 Received: (qmail 81969 invoked by uid 0); 24 Jun 2007 16:18:53 -0000 Received: from 124.43.228.239 (HELO ?192.168.101.103?) (124.43.228.239) by relay03.pair.com with SMTP; 24 Jun 2007 16:18:53 -0000 X-pair-Authenticated: 124.43.228.239 Message-ID: <467E996A.9090505@opensource.lk> Date: Sun, 24 Jun 2007 21:48:50 +0530 From: Sanjiva Weerawarana Organization: WSO2 Inc. User-Agent: Thunderbird 1.5.0.12 (X11/20070604) MIME-Version: 1.0 To: abdera-dev@incubator.apache.org Subject: Re: date header patch References: <29a761a00706121004j685d886bt7ee8a59e83c76bc5@mail.gmail.com> <466EDD06.7000806@gmail.com> <29a761a00706121115t7d4224baoc4e4d1e3d3f62bc5@mail.gmail.com> In-Reply-To: <29a761a00706121115t7d4224baoc4e4d1e3d3f62bc5@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org Its the mailing list. The proper procedure is to open a JIRA and attach the patch there .. that gives you the chance to make clear you're giving Apache a license for your patch etc.. Sanjiva. Brian Moseley wrote: > On 6/12/07, James M Snell wrote: >> No patch attached. > > i don't know who's stripping the attachment, gmail or the mailing list > manager, but that's really annoying. > > Index: > server/src/main/java/org/apache/abdera/protocol/server/servlet/HttpServletRequestContext.java > > =================================================================== > --- > server/src/main/java/org/apache/abdera/protocol/server/servlet/HttpServletRequestContext.java > (revision > 546524) > +++ > server/src/main/java/org/apache/abdera/protocol/server/servlet/HttpServletRequestContext.java > (working > copy) > @@ -144,7 +144,8 @@ > } > > public Date getDateHeader(String name) { > - return new Date(request.getDateHeader(name)); > + long value = request.getDateHeader(name); > + return value != -1 ? new Date(value) : null; > } > > public String getHeader(String name) { > -- Sanjiva Weerawarana, Ph.D. Founder & Director; Lanka Software Foundation; http://www.opensource.lk/ Founder, Chairman & CEO; WSO2, Inc.; http://www.wso2.com/ Director; Open Source Initiative; http://www.opensource.org/ Member; Apache Software Foundation; http://www.apache.org/ Visiting Lecturer; University of Moratuwa; http://www.cse.mrt.ac.lk/