Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: abdera-dev@incubator.apache.org
Received-SPF: pass (herse.apache.org: domain of ixjonez@gmail.com designates
 66.249.90.179 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=beta;
        h=received:message-id:date:from:sender:to:subject:mime-version:content-type:content-transfer-encoding:content-disposition:x-google-sender-auth;
        b=hK1iHiKyHBEDG0JC3/ikjVPc3qc2zBLzQoaDIk2flgh37tDVqO7PMf+AQV6/JsTaXkN7DLXhm5SGYl/SvxAhlZ2DXiaB+l2q9Jdijq+UeDGYR/oAnBxSpod2Qih5cZt5qtEfUqlLniGiSILAYUcNTZjNzfyuAQvjqUHf767gyao=
Message-ID: <29a761a00704241200s4863c940h635c8b531414b683@mail.gmail.com>
Date: Tue, 24 Apr 2007 12:00:10 -0700
From: "Brian Moseley" <bcm@osafoundation.org>
Sender: ixjonez@gmail.com
To: abdera-dev@incubator.apache.org
Subject: conditional method request headers in the server framework
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

are there any thoughts on supporting the HTTP request headers that
support conditional methods (If-Match, If-Modified-Since,
If-None-Match, If-Unmodified-Since) in the server framework?

i've added preliminary support in my Provider implementation for
If-Match and If-None-Match, which you can see in the following two
classes:

<http://viewcvs.osafoundation.org/server/cosmo/trunk/cosmo/src/main/java/org/osaf/cosmo/atom/provider/StandardProvider.java?rev=4186&view=markup>
have a look at updateEntry() and checkConditionals().

<http://viewcvs.osafoundation.org/server/cosmo/trunk/cosmo/src/main/java/org/osaf/cosmo/http/IfMatch.java?rev=4186&view=markup>
<http://viewcvs.osafoundation.org/server/cosmo/trunk/cosmo/src/main/java/org/osaf/cosmo/http/IfNoneMatch.java?rev=4186&view=markup>

i'm thinking it might be better to do these checks in
AbstractRequestHandler's process() or preconditions() methods. we'd
need a way to get the etag for the current state of the target
resource, probably a Target.getEntityTag method.

i haven't taken a crack at If-Modified-Since/If-Unmodified-Since yet,
but that probably requires a Target.getLastModified method and similar
checks to the If-Match/If-None-Match ones. and there's a little bit of
interaction between these two sets of headers that depend on the
method. but i don't think i'll find any surprises there.

if this sounds ok, i'll open a jira and work up a patch. thoughts?