abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James M Snell <jasn...@gmail.com>
Subject Re: svn commit: r469180 - in /incubator/abdera/java/trunk: core/src/main/java/org/apache/abdera/factory/ core/src/main/java/org/apache/abdera/model/ examples/src/main/java/org/apache/abdera/examples/extension/ examples/src/main/resources/META-INF/ ex
Date Fri, 03 Nov 2006 21:48:39 GMT
Possibly yes. I'll take a look

Garrett Rooney wrote:
> [snip]
> Nice work James!  A few comments:
> 
>> +  void setElementWrapper(Element element, Element wrapper);
> 
> Are we sure this should be part of the Factory interface?  It looks
> like every place it's used we've already cast to FOMFactory, so could
> it just live there?  I'm not sure if a new parser back end would keep
> track of element wrappers in the same way.
> 
>> +public class InReplyToImpl
>> +  extends ElementWrapper
>> +  implements InReplyTo {
> 
> Does it still make sense to have separate Impl classes and interfaces
> for the thread code?
> 
> -garrett
> 

Mime
View raw message