Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: abdera-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of rooneg@gmail.com designates
 66.249.82.235 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=Cqc2lr8nXySi0x2y1wDB536xpjmJeDppjhbEs774XslJkiy+rreoh6nOa9cnW9F7+T6nM5LHtywWiR9OWjLKQ9xP/sdJYIsdbcMJ8JJmQ+oCkNIUaDNirIEV04jHHF2t5gMxwpfhbjMIMJIBWaYBRb+yqr049qYxUMOiwd4t2ZE=
Message-ID: <7edfeeef0608071041geda5699s3869b06171c94f4f@mail.gmail.com>
Date: Mon, 7 Aug 2006 13:41:58 -0400
From: "Garrett Rooney" <rooneg@electricjellyfish.net>
Sender: rooneg@gmail.com
To: abdera-dev@incubator.apache.org
Subject: Re: svn commit: r429409 - in
 /incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol:
 cache/CacheBase.java cache/InMemoryCache.java client/RequestOptions.java
 client/ResponseBase.java
In-Reply-To: <20060807173603.6E1ED1A981A@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20060807173603.6E1ED1A981A@eris.apache.org>

On 8/7/06, jmsnell@apache.org <jmsnell@apache.org> wrote:
> Author: jmsnell
> Date: Mon Aug  7 10:36:02 2006
> New Revision: 429409
>
> URL: http://svn.apache.org/viewvc?rev=429409&view=rev
> Log:
> Had a bit of a brain fart on the bitwise operators
>
> Modified:
>     incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/CacheBase.java
>     incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/InMemoryCache.java
>     incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/client/RequestOptions.java
>     incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/client/ResponseBase.java
>
> Modified: incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/CacheBase.java
> URL: http://svn.apache.org/viewvc/incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/CacheBase.java?rev=429409&r1=429408&r2=429409&view=diff
> ==============================================================================
> --- incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/CacheBase.java (original)
> +++ incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/CacheBase.java Mon Aug  7 10:36:02 2006
> @@ -122,6 +122,10 @@
>      RequestOptions options,
>      Response response) {
>      CacheKey key = getCacheKey(uri, options,response);
> +System.out.println(response);
> +System.out.println(response.isNoStore());
> +System.out.println(options);
> +System.out.println(options.getNoStore());
>      if ((response != null && response.isNoStore()) ||
>          options != null && options.getNoStore()) {
>       remove(key);

That probably wasn't intended...

> Modified: incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/InMemoryCache.java
> URL: http://svn.apache.org/viewvc/incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/InMemoryCache.java?rev=429409&r1=429408&r2=429409&view=diff
> ==============================================================================
> --- incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/InMemoryCache.java (original)
> +++ incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/InMemoryCache.java Mon Aug  7 10:36:02 2006
> @@ -46,7 +46,7 @@
>    }
>
>    public CachedResponse get(
> -    CacheKey key) {
> +    CacheKey key) {
>        return cache.get(key);
>    }

Is this just a whitespace change?  No objection to those, but they
should be committed separately.

-garrett