abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Garrett Rooney" <roo...@electricjellyfish.net>
Subject Re: svn commit: r433823 [1/3] - in /incubator/abdera/java/trunk: client/src/main/java/org/apache/abdera/protocol/cache/ client/src/main/java/org/apache/abdera/protocol/client/ client/src/main/java/org/apache/abdera/protocol/util/ client/src/test/java
Date Wed, 23 Aug 2006 12:57:25 GMT
On 8/22/06, jmsnell@apache.org <jmsnell@apache.org> wrote:
> Author: jmsnell
> Date: Tue Aug 22 18:13:27 2006
> New Revision: 433823
>
> URL: http://svn.apache.org/viewvc?rev=433823&view=rev
> Log:
> Big update.
>
> Replace the nnn.INSTANCE mechanism with a new Abdera class.  The static configuration
model
> is replaced to improve thread safety and better deal with class loaders.
>
> instead of
>
>   Parser.INSTANCE.parse(...)
>
> you'll now do:
>
>   Abdera abdera = new Abdera();
>   abdera.getParser().parse(...)
>
> or
>
>   Abdera.getNewParser().parse(...)
>
> Included in this are also a number of fixes to the tests.  I know it's bad practice to
roll
> multiple updates into one, but I wanted to make sure all of the tests were passing when
I
> checked this in.

Ok, so no argument that making the tests pass is a good thing, but
there are things in here that look like new features and have nothing
to do with actually fixing existing tests.  The SSL stuff in the
client code for example.  Please at least go back and document what
was changed in the log message.

> The Cache Tests have been disabled because of a problem running the tests from Ant.
> The cache tests work great in Eclipse, but don't seem to work properly from Ant. Not
sure
> why.

If you're going to comment something out to keep it from running, at
least leave a note next to it about why.  If you get hit by a bus
tomorrow you want to make sure the next person who looks at those
tests can tell why they were commented out.

-garrett

Mime
View raw message