abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Elias Torres <el...@torrez.us>
Subject Re: svn commit: r432780 - /incubator/abdera/java/trunk/extensions/src/main/java/org/apache/abdera/ext/json/JSONWriter.java
Date Sat, 19 Aug 2006 20:19:46 GMT
Fixed.

-Elias

Garrett Rooney wrote:
> On 8/18/06, eliast@apache.org <eliast@apache.org> wrote:
>> Author: eliast
>> Date: Fri Aug 18 19:11:25 2006
>> New Revision: 432780
>>
>> URL: http://svn.apache.org/viewvc?rev=432780&view=rev
>> Log:
>> - Fixed bug which had atom:content type attribute values uppercased
>> - Added quote() call in entry.content.value
>> - Removed redundant code and turned it into functions.
>>
>> Modified:
>>    
>> incubator/abdera/java/trunk/extensions/src/main/java/org/apache/abdera/ext/json/JSONWriter.java
>>
>>
>> Modified:
>> incubator/abdera/java/trunk/extensions/src/main/java/org/apache/abdera/ext/json/JSONWriter.java
>>
>> URL:
>> http://svn.apache.org/viewvc/incubator/abdera/java/trunk/extensions/src/main/java/org/apache/abdera/ext/json/JSONWriter.java?rev=432780&r1=432779&r2=432780&view=diff
>>
>> ==============================================================================
>>
>> ---
>> incubator/abdera/java/trunk/extensions/src/main/java/org/apache/abdera/ext/json/JSONWriter.java
>> (original)
>> +++
>> incubator/abdera/java/trunk/extensions/src/main/java/org/apache/abdera/ext/json/JSONWriter.java
>> Fri Aug 18 19:11:25 2006
>> @@ -20,8 +20,11 @@
>>
>>  import java.io.IOException;
>>  import java.io.OutputStream;
>> +import java.net.URISyntaxException;
>>  import java.util.List;
>>
>> +import javax.activation.MimeTypeParseException;
>> +
>>  import org.apache.abdera.model.Base;
>>  import org.apache.abdera.model.Category;
>>  import org.apache.abdera.model.Collection;
>> @@ -37,6 +40,7 @@
>>  import org.apache.abdera.model.Content.Type;
>>  import org.apache.abdera.writer.NamedWriter;
>>  import org.json.JSONArray;
>> +import org.json.JSONException;
>>  import org.json.JSONObject;
>>
>>  public class JSONWriter implements NamedWriter {
>> @@ -93,6 +97,23 @@
>>
>>      if(entry.getSummary() != null)
>>          jsentry.put("summary", entry.getSummary());
>> +
>> +    if(entry.getId() != null)
>> +        jsentry.put("id", entry.getId().toString());
>> +
>> +    if(entry.getUpdated() != null)
>> +        jsentry.put("updated", entry.getUpdated().toString());
>> +
>> +    if(entry.getPublished() != null)
>> +        jsentry.put("published", entry.getPublished().toString());
> 
> In the interest of consistency, could we please put spaces after the
> if and before the paren?  The rest of this file was already formatted
> this way, and it seems like all the ifs this change added leave out
> the space.
> 
> -garrett
> 

Mime
View raw message