abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James M Snell <jasn...@gmail.com>
Subject Re: svn commit: r429409 - in /incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol: cache/CacheBase.java cache/InMemoryCache.java client/RequestOptions.java client/ResponseBase.java
Date Mon, 07 Aug 2006 17:48:00 GMT
Sorry, I keep getting distracted here on this end.  Just committed
another one where I realized the log message was wrong.. after
committing it.  In any case, the code should be ok, even if the person
committing needs a few whacks upside the head.

- James

Garrett Rooney wrote:
> On 8/7/06, jmsnell@apache.org <jmsnell@apache.org> wrote:
>> Author: jmsnell
>> Date: Mon Aug  7 10:36:02 2006
>> New Revision: 429409
>>
>> URL: http://svn.apache.org/viewvc?rev=429409&view=rev
>> Log:
>> Had a bit of a brain fart on the bitwise operators
>>
>> Modified:
>>    
>> incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/CacheBase.java
>>
>>    
>> incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/InMemoryCache.java
>>
>>    
>> incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/client/RequestOptions.java
>>
>>    
>> incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/client/ResponseBase.java
>>
>>
>> Modified:
>> incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/CacheBase.java
>>
>> URL:
>> http://svn.apache.org/viewvc/incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/CacheBase.java?rev=429409&r1=429408&r2=429409&view=diff
>>
>> ==============================================================================
>>
>> ---
>> incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/CacheBase.java
>> (original)
>> +++
>> incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/CacheBase.java
>> Mon Aug  7 10:36:02 2006
>> @@ -122,6 +122,10 @@
>>      RequestOptions options,
>>      Response response) {
>>      CacheKey key = getCacheKey(uri, options,response);
>> +System.out.println(response);
>> +System.out.println(response.isNoStore());
>> +System.out.println(options);
>> +System.out.println(options.getNoStore());
>>      if ((response != null && response.isNoStore()) ||
>>          options != null && options.getNoStore()) {
>>       remove(key);
> 
> That probably wasn't intended...
> 
>> Modified:
>> incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/InMemoryCache.java
>>
>> URL:
>> http://svn.apache.org/viewvc/incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/InMemoryCache.java?rev=429409&r1=429408&r2=429409&view=diff
>>
>> ==============================================================================
>>
>> ---
>> incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/InMemoryCache.java
>> (original)
>> +++
>> incubator/abdera/java/trunk/client/src/main/java/org/apache/abdera/protocol/cache/InMemoryCache.java
>> Mon Aug  7 10:36:02 2006
>> @@ -46,7 +46,7 @@
>>    }
>>
>>    public CachedResponse get(
>> -    CacheKey key) {
>> +    CacheKey key) {
>>        return cache.get(key);
>>    }
> 
> Is this just a whitespace change?  No objection to those, but they
> should be committed separately.
> 
> -garrett
> 

Mime
View raw message