Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: abdera-dev@incubator.apache.org
Received-SPF: pass (asf.osuosl.org: domain of rooneg@gmail.com designates
 64.233.182.186 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth;
        b=s5ZnwL2AhPrfBd8r8uhSpXuAG06H8rUJ+c0eya6R9OjS95oLcumGD2bs8w7AXIM2JvvTPGq4KoDJTT3oG4M8/M9Ls9KKVPLFyMxpedvRtSOol0oXi2KN/8fi5JEk8zYYEfGkyDfs1G+pZYPFdXErkJ00W8raYNSsNPN9u2FWl0A=
Message-ID: <7edfeeef0607101654u1d021a33rafcf0882f0f903af@mail.gmail.com>
Date: Mon, 10 Jul 2006 19:54:17 -0400
From: "Garrett Rooney" <rooneg@electricjellyfish.net>
Sender: rooneg@gmail.com
To: abdera-dev@incubator.apache.org
Subject: Re: svn commit: r420662 [1/2] - in /incubator/abdera/java/trunk:
 core/src/main/java/org/apache/abdera/factory/
 parser/src/main/java/org/apache/abdera/parser/stax/
 parser/src/test/java/org/apache/abdera/test/parser/stax/
Cc: abdera-commits@incubator.apache.org
In-Reply-To: <20060710234225.904C41A981A@eris.apache.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <20060710234225.904C41A981A@eris.apache.org>

On 7/10/06, jmsnell@apache.org <jmsnell@apache.org> wrote:
> Author: jmsnell
> Date: Mon Jul 10 16:42:23 2006
> New Revision: 420662
>
> URL: http://svn.apache.org/viewvc?rev=420662&view=rev
> Log:
> Factory interface simplifications
> Removed most of the convenience methods that are already available via the other interfaces
> Simplified the alternatives impl

There are a few changes in here that don't seem to be related to this...

Specifically,

> +++ incubator/abdera/java/trunk/parser/src/main/java/org/apache/abdera/parser/stax/FOMContent.java Mon Jul 10 16:42:23 2006
> @@ -127,6 +127,10 @@
>      if (value != null) {
>        if (this.getFirstElement() != null)
>          this.getFirstElement().discard();
> +      if (value instanceof Div && !type.equals(Content.Type.XML))
> +        init(Content.Type.XHTML);
> +      else
> +        init(Content.Type.XML);
>        this.setFirstChild((OMElement)value);
>      } else {
>        _removeAllChildren();

And this:

> +++ incubator/abdera/java/trunk/parser/src/main/java/org/apache/abdera/parser/stax/FOMText.java Mon Jul 10 16:42:23 2006
> @@ -106,6 +106,7 @@
>      if (value != null) {
>        if (this.getFirstChildWithName(Constants.DIV) != null)
>          this.getFirstChildWithName(Constants.DIV).discard();
> +      init(Text.Type.XHTML);
>        this.setFirstChild((OMElement)value);
>      } else
>        _removeAllChildren();

It's really best to get into the habit of making each change do only
one thing, rather than mixing them together like this...

-garrett