Return-Path: Delivered-To: apmail-incubator-abdera-dev-archive@locus.apache.org Received: (qmail 64072 invoked from network); 13 Jul 2006 22:11:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 13 Jul 2006 22:11:55 -0000 Received: (qmail 50134 invoked by uid 500); 13 Jul 2006 22:11:53 -0000 Delivered-To: apmail-incubator-abdera-dev-archive@incubator.apache.org Received: (qmail 50122 invoked by uid 500); 13 Jul 2006 22:11:53 -0000 Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: abdera-dev@incubator.apache.org Delivered-To: mailing list abdera-dev@incubator.apache.org Received: (qmail 50106 invoked by uid 99); 13 Jul 2006 22:11:53 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jul 2006 15:11:53 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of sayrer@gmail.com designates 64.233.182.189 as permitted sender) Received: from [64.233.182.189] (HELO nf-out-0910.google.com) (64.233.182.189) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Jul 2006 15:11:51 -0700 Received: by nf-out-0910.google.com with SMTP id x4so21005nfb for ; Thu, 13 Jul 2006 15:11:30 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=L9gzzvM17N686hf1BniqPB8CaMQaw3zEfxU1SQgwwPYUi76gzsdQI9ZymTIAKo8jkw8V8IzSX8miCk0CPWpbu0YEDlk3/XP5ChfHhYJyJRaMjR4THMKSrwZWOgOMjspflItduwF1cFMk1ONaPtQodhGXyzAKlYmxfjajP6yUt+A= Received: by 10.48.157.1 with SMTP id f1mr1353502nfe; Thu, 13 Jul 2006 15:11:30 -0700 (PDT) Received: by 10.49.40.10 with HTTP; Thu, 13 Jul 2006 15:11:30 -0700 (PDT) Message-ID: <68fba5c50607131511w5238648dre9df1334fc9bb638@mail.gmail.com> Date: Thu, 13 Jul 2006 18:11:30 -0400 From: "Robert Sayre" To: abdera-dev@incubator.apache.org Subject: Re: Model api changes In-Reply-To: <7edfeeef0607131330j3063325en7ed76478437958d@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <44B6A805.2040307@gmail.com> <7edfeeef0607131330j3063325en7ed76478437958d@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N On 7/13/06, Garrett Rooney wrote: > On 7/13/06, James M Snell wrote: > > There are a number of aspects of the model api that have been bugging me > > for some time. > > > > For instance, > > > > Feed.getEntries() returns a List, however, Feed.getEntries().add(...) > > doesn't actually do anything. It makes more sense for Feed.getEntries() > > to return an Iterator given that it's primary purpose is iterating > > through the entries. Doing so also allows us to optimize the underlying > > Axiom code (which provides efficient element iterators). > > Returning an Iterator at least makes it clear > that there was no deep copy type semantics going on. FWIW, the Java convention is to use a List. See Collections.unmodifiableList(), etc. -- Robert Sayre "I would have written a shorter letter, but I did not have the time."