Return-Path: Delivered-To: apmail-incubator-abdera-dev-archive@locus.apache.org Received: (qmail 72242 invoked from network); 14 Jul 2006 15:29:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 14 Jul 2006 15:29:42 -0000 Received: (qmail 85416 invoked by uid 500); 14 Jul 2006 15:29:40 -0000 Delivered-To: apmail-incubator-abdera-dev-archive@incubator.apache.org Received: (qmail 85346 invoked by uid 500); 14 Jul 2006 15:29:40 -0000 Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: abdera-dev@incubator.apache.org Delivered-To: mailing list abdera-dev@incubator.apache.org Received: (qmail 85327 invoked by uid 99); 14 Jul 2006 15:29:40 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jul 2006 08:29:40 -0700 X-ASF-Spam-Status: No, hits=0.5 required=10.0 tests=DNS_FROM_RFC_ABUSE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of jasnell@gmail.com designates 64.233.184.233 as permitted sender) Received: from [64.233.184.233] (HELO wr-out-0506.google.com) (64.233.184.233) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Jul 2006 08:29:39 -0700 Received: by wr-out-0506.google.com with SMTP id i7so259598wra for ; Fri, 14 Jul 2006 08:29:19 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type:content-transfer-encoding; b=cv+hbyQe+uVcdqGQQdrRRaZwDQ83NLpZb1meDIMUEvV2q5vrKEVTdjAm8GL0dMlRH4T3amc5ouXIIZN90T0bz9499ublPMUuiANa/OyyDroiDPOWdI6nIGo5E0wm0yxnyRXCBaczTW2uou/MJmwgL5+5qnhTUI2Eu0EpmZQtFTY= Received: by 10.54.149.6 with SMTP id w6mr2487737wrd; Fri, 14 Jul 2006 08:29:19 -0700 (PDT) Received: from ?192.168.1.104? ( [67.181.218.96]) by mx.gmail.com with ESMTP id g5sm2654278wra.2006.07.14.08.29.18; Fri, 14 Jul 2006 08:29:18 -0700 (PDT) Message-ID: <44B7B84A.6050205@gmail.com> Date: Fri, 14 Jul 2006 08:29:14 -0700 From: James M Snell User-Agent: Thunderbird 1.5.0.4 (X11/20060516) MIME-Version: 1.0 To: abdera-dev@incubator.apache.org Subject: Re: svn commit: r421809 [1/2] - in /incubator/abdera/java/trunk: core/src/main/java/org/apache/abdera/model/ examples/src/main/java/org/apache/abdera/examples/appclient/ examples/src/main/java/org/apache/abdera/examples/simple/ extensions/src/main/ja References: <7edfeeef0607140518n36e4befdnc367b4918c0cbd88@mail.gmail.com> In-Reply-To: <7edfeeef0607140518n36e4befdnc367b4918c0cbd88@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N There are a variety of things here. For instance, FOMElement used to have an internal _setAttributeValue method before it had a public setAttributeValue method... I had never before actually managed to get around to removing it. Also, FOMEntry and FOMSource used duplicate code to do things like generate a listing of Categories and Links with specific attribute values, now there is a FOMHelper that contains that code. To help with iterating through link and category elements incrementally, there are now a couple of special iterators that are modeled after the kinds of iterators Axiom provides. - James Garrett Rooney wrote: > [snip] >> A number of other improvements and simplifications have been made to the >> parser implementation. More work is likely necessary but this is, at >> least, a step in the right direction. > > Can you be more specific about what kind of improvements and > simplficiations? This is kind of vague. > > -garrett >