abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Duncan" <stephen.dun...@gmail.com>
Subject Re: Model api changes
Date Thu, 13 Jul 2006 22:09:37 GMT
On 7/13/06, James M Snell <jasnell@gmail.com> wrote:
> There are a number of aspects of the model api that have been bugging me
> for some time.
>
> For instance,
>
> Feed.getEntries() returns a List, however, Feed.getEntries().add(...)
> doesn't actually do anything.  It makes more sense for Feed.getEntries()
> to return an Iterator given that it's primary purpose is iterating
> through the entries.  Doing so also allows us to optimize the underlying
>  Axiom code (which provides efficient element iterators).
>
> There are also methods such as setCategories(List) that accept a list
> that I'd like to remove mainly because I haven't yet come across a use
> case in which building up the list of items separately then setting them
> on the element makes any sense.

I'm not sure about this one, but I can't think of anything off hand,
and I'm totally in favor of getting rid of things with the concept "we
can always add it back in later" if somebody comes forward with a use
case that requires it.

> These changes would simplify and optimize the api a bit more.
>
> If there are no objections, I can check in a fix today.
>
> - James
>


-- 
Stephen Duncan Jr
www.stephenduncanjr.com

Mime
View raw message