abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James M Snell <jasn...@gmail.com>
Subject Re: Model api changes
Date Thu, 13 Jul 2006 22:17:19 GMT
Well aware, however, using list (even unmodifiable ones) in this case
has a number of unfortunate downsides, not the least of which is causing
the pull parser to consume the stream before it returns.  We can
preserve the incremental parse model by using an iterator instead.

- James

Robert Sayre wrote:
> On 7/13/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
>> On 7/13/06, James M Snell <jasnell@gmail.com> wrote:
>> > There are a number of aspects of the model api that have been
>> bugging me
>> > for some time.
>> >
>> > For instance,
>> >
>> > Feed.getEntries() returns a List, however, Feed.getEntries().add(...)
>> > doesn't actually do anything.  It makes more sense for
>> Feed.getEntries()
>> > to return an Iterator given that it's primary purpose is iterating
>> > through the entries.  Doing so also allows us to optimize the
>> underlying
>> >  Axiom code (which provides efficient element iterators).
>>
>>  Returning an Iterator at least makes it clear
>> that there was no deep copy type semantics going on.
> 
> FWIW, the Java convention is to use a List. See
> Collections.unmodifiableList(), etc.
> 

Mime
View raw message