Return-Path: Delivered-To: apmail-incubator-abdera-dev-archive@locus.apache.org Received: (qmail 44824 invoked from network); 18 Jun 2006 16:29:09 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 Jun 2006 16:29:09 -0000 Received: (qmail 28631 invoked by uid 500); 18 Jun 2006 16:29:08 -0000 Delivered-To: apmail-incubator-abdera-dev-archive@incubator.apache.org Received: (qmail 28616 invoked by uid 500); 18 Jun 2006 16:29:08 -0000 Mailing-List: contact abdera-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: abdera-dev@incubator.apache.org Delivered-To: mailing list abdera-dev@incubator.apache.org Received: (qmail 28606 invoked by uid 99); 18 Jun 2006 16:29:08 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Jun 2006 09:29:08 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=RCVD_IN_BL_SPAMCOP_NET,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: domain of stephen.duncan@gmail.com designates 66.249.92.168 as permitted sender) Received: from [66.249.92.168] (HELO ug-out-1314.google.com) (66.249.92.168) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Jun 2006 09:29:07 -0700 Received: by ug-out-1314.google.com with SMTP id q2so2301930uge for ; Sun, 18 Jun 2006 09:28:46 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=GPMcsdUXefdDfLyMotVzpX20XJFr/6vRqCUSbfT3sl6YpxXcOpG6QqdhIdeNxleJE5hDKa0uupMy7LPVBt/TdKy+3FaRYLbSX6jSWFrL8ODDseUXat28EPoRzT8P8kYzslco96I9XxQ+67hPv9Mi8bOkhmKjw0BLM8THQexnMPM= Received: by 10.78.67.20 with SMTP id p20mr1649553hua; Sun, 18 Jun 2006 09:28:46 -0700 (PDT) Received: by 10.78.53.20 with HTTP; Sun, 18 Jun 2006 09:28:46 -0700 (PDT) Message-ID: Date: Sun, 18 Jun 2006 12:28:46 -0400 From: "Stephen Duncan" To: abdera-dev@incubator.apache.org Subject: Re: Abdera Unit Tests and Network Access In-Reply-To: <7edfeeef0606180626u43d74485k570e6539beb16940@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <7edfeeef0606180626u43d74485k570e6539beb16940@mail.gmail.com> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N +1. It will also make the tests faster... -Stephen On 6/18/06, Garrett Rooney wrote: > One of the things that kind of bothers me about the current Abdera > unit tests is that they require network access to function. It's > basically impossible (assuming that we have the tests running, which > we don't for the ant build right now, but that's a separate issue) to > run the tests (and by extension to build a release, since one step in > building a release is running the tests) if you don't have unfetterred > access to the internet. It also means that our tests can now fail due > to conditions totally outside our control. > > I'd like to start working on bringing the Atom files we depend on into > our source tree, at least the ones that are under a sufficiently clear > license (Mark Pilgrim's Feed Parser tests, for example, are clearly > under the Python Software Foundation license, which AFAICT is just a > standard BSDish license and thus we can use that code as long as we > clearly reproduce its license in our NOTICE file and don't remove any > copyright statements). > > Does anyone have an objection to this? If we want to preserve the > ability to fetch the files from their cannonical locations online I > can certainly look at a more complex system that provides that > ability, but honestly it seems like the point here is to test our > ability to parse the content, not the JDK's ability to download a file > via http. > > -garrett > -- Stephen Duncan Jr www.stephenduncanjr.com