abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Duncan" <stephen.dun...@gmail.com>
Subject Re: svn commit: r415090 - in /incubator/abdera/java/trunk: build/build.xml dependencies/deps.properties parser/pom.xml pom.xml
Date Sun, 18 Jun 2006 16:30:08 GMT
I'll make sure to keep my patches separated from here on out.  It'll
be better when we have JIRA so that patches can be attached to an
issue, and feel less likely to be lost in the ether of the mailing
list...

-Stephen

On 6/18/06, Garrett Rooney <rooneg@electricjellyfish.net> wrote:
> On 6/18/06, jmsnell@apache.org <jmsnell@apache.org> wrote:
> > Author: jmsnell
> > Date: Sat Jun 17 21:53:13 2006
> > New Revision: 415090
> >
> > URL: http://svn.apache.org/viewvc?rev=415090&view=rev
> > Log:
> > Various build patches from Stephen and Garrett
>
> Thanks for checking this in James.  A few small comments.
>
> The two changes were really unrelated, and thus should have been
> checked in separately.  Committing changes as separate revisions makes
> it easier to merge them between branches and to look at via diff
> later.  Subversion's concept of a global revision that indicates the
> entire state of the tree makes it quite easy to do things like that,
> but only if the changes that are all committed together are actually
> associated with one another.
>
> Second, I did provide a fairly detailed log message to go along with
> my patch.  I'm a big fan of actually describing what changed in a
> commit in the log, as opposed to logs like this one that basically
> just says "Garrett and Stephen changed the build".
>
> Finally, when you commit a change that was posted via email, it's good
> practice to respond to the email and say it's been committed, that way
> other people who are potentially going to be checking in changes will
> be aware that these ones are already taken care of.  Again, not a huge
> deal, but one that makes this sort of thing work a little more
> smoothly.
>
> -garrett
>


-- 
Stephen Duncan Jr
www.stephenduncanjr.com

Mime
View raw message