abdera-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James M Snell <jasn...@gmail.com>
Subject Re: Tabs versus Spaces (was Re: svn commit: r415780 - /incubator/abdera/java/trunk/server/src/main/java/org/apache/abdera/server/servlet/ServletRequestContext.java)
Date Tue, 20 Jun 2006 20:25:22 GMT
To this point, the style I've been using as been the two-spaces indent
for everything.  Tabs are evil.  Let's stick to the spaces please.

- James

Garrett Rooney wrote:
> On 6/20/06, eliast@apache.org <eliast@apache.org> wrote:
> 
>> @@ -65,6 +65,9 @@
>>                 buffer.append(servletRequest.getLocalPort());
>>         }
>>         buffer.append(servletRequest.getServletPath());
>> +
>> +  // So that .resolve() works appropriately.
>> +  buffer.append("/");
>>         try {
>>                 return new URI(buffer.toString());
>>         } catch (URISyntaxException e) {
> 
> This commit is a perfect example of something I've been wanting to bring
> up...
> 
> The abdera codebase currently mixes tabs and spaces in its indenting.
> This wouldn't be so bad, except that it assumes that tab == two
> spaces, which means that when you look at the code in many tools it'll
> look all screwy because the default definition for tab stops are 8
> spaces...
> 
> The end result is that you get diffs like this, where the indenting is
> all screwed up.  It also means that when I open the files in any of
> the various editors I use it looks weird, which annoys me ;-)
> 
> I'd personally prefer if we could move towards a style that simply
> always uses spaces, thus avoiding this problem entirely.  If we do
> want to do that, I'd suggest we do so soon, and in a sweeping commit
> that ONLY changes that, so that we can get it over with and avoid
> screwing up our revision history with that sort of sweeping change
> later on in the project's life cycle.
> 
> Thoughts?
> 
> -garrett
> 

Mime
View raw message