Mailing-List: contact abdera-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: abdera-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of jasnell@gmail.com designates
 64.233.178.251 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:x-enigmail-version:content-type:content-transfer-encoding;
        b=pn587Rp+452xPMQD/LvWDOP0qUVvzSHk1FAPOHjZL1Qymg9XlQ0BrdhcqTvqIeUcvB/VeAwygadGSkUoVItB7H/wgsopNeq5hokG4uWa8/McWBXy96D8b+DJunsObAMK0n9CzC/1e++JApi8zCpLrQHuz81gjwk4oV5wauUwL+U=
Message-ID: <47B26DB7.8050308@gmail.com>
Date: Tue, 12 Feb 2008 20:10:31 -0800
From: James M Snell <jasnell@gmail.com>
User-Agent: Thunderbird 2.0.0.6 (X11/20071022)
MIME-Version: 1.0
To: abdera-dev@incubator.apache.org
CC: abdera-commits@incubator.apache.org
Subject: Re: svn commit: r627173 - in
 /incubator/abdera/java/trunk/adapters/couchdb:
 readme
 src/main/java/org/apache/abdera/protocol/server/adapters/couchdb/CouchDbAdapter.java
References: <20080212231002.AA8611A983E@eris.apache.org>
 <47B26313.3030008@mulesource.com>
In-Reply-To: <47B26313.3030008@mulesource.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Yep, sorry, old habits die hard, especially the bad ones.

- James

Dan Diephouse wrote:
> Re: empty catch block - can we at least put a notice of why we're not 
> doing anything with that exception? And what happens if its a 
> runtimeexception? Is there something more specific we can catch than 
> Exception?
> - Dan
> 
> jmsnell@apache.org wrote:
>> Author: jmsnell
>> Date: Tue Feb 12 15:10:01 2008
>> New Revision: 627173
>>
>> URL: http://svn.apache.org/viewvc?rev=627173&view=rev
>> Log:
>> mention that the html and json jars are also required
>> handle an error condition properly in getEntry
>>
>> Modified:
>>     incubator/abdera/java/trunk/adapters/couchdb/readme
>>     
>> incubator/abdera/java/trunk/adapters/couchdb/src/main/java/org/apache/abdera/protocol/server/adapters/couchdb/CouchDbAdapter.java 
>>
>>
>> Modified: incubator/abdera/java/trunk/adapters/couchdb/readme
>> URL: 
>> http://svn.apache.org/viewvc/incubator/abdera/java/trunk/adapters/couchdb/readme?rev=627173&r1=627172&r2=627173&view=diff 
>>
>> ============================================================================== 
>>
>> --- incubator/abdera/java/trunk/adapters/couchdb/readme (original)
>> +++ incubator/abdera/java/trunk/adapters/couchdb/readme Tue Feb 12 
>> 15:10:01 2008
>> @@ -3,6 +3,7 @@
>>  Dependencies:  
>>    * Abdera Core, Parser, Protocol, Server modules
>> +  * Abdera json and html extensions
>>    * CouchDb4J 
>> (http://www.couchdbwiki.com/index.php?title=Getting_Started_with_Java)
>>     Using the Adapter:
>>
>> Modified: 
>> incubator/abdera/java/trunk/adapters/couchdb/src/main/java/org/apache/abdera/protocol/server/adapters/couchdb/CouchDbAdapter.java 
>>
>> URL: 
>> http://svn.apache.org/viewvc/incubator/abdera/java/trunk/adapters/couchdb/src/main/java/org/apache/abdera/protocol/server/adapters/couchdb/CouchDbAdapter.java?rev=627173&r1=627172&r2=627173&view=diff 
>>
>> ============================================================================== 
>>
>> --- 
>> incubator/abdera/java/trunk/adapters/couchdb/src/main/java/org/apache/abdera/protocol/server/adapters/couchdb/CouchDbAdapter.java 
>> (original)
>> +++ 
>> incubator/abdera/java/trunk/adapters/couchdb/src/main/java/org/apache/abdera/protocol/server/adapters/couchdb/CouchDbAdapter.java 
>> Tue Feb 12 15:10:01 2008
>> @@ -212,7 +212,10 @@
>>        String entry = target.getParameter("entry");
>>        Session session = new Session(host,port);
>>        Database db = session.getDatabase(feed);
>> -      Document doc = db.getDocument(entry);
>> +      Document doc = null;
>> +      try {
>> +        doc = db.getDocument(entry);
>> +      } catch (Exception e) {}
>>        if (doc != null)
>>          return new JsonObjectResponseContext(
>>            request.getAbdera(),
>>
>>
>>   
> 
>